# CVE-2023-34236: Information Disclosure Vulnerability in Weave GitOps Terraform Controller

> Authenticated attackers can view sensitive data in pod logs, potentially leading to unauthorized access to Terraform-managed resources.

- **Severity:** High 8.5 (`CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:L/A:N`)
- **Exploited in the wild:** Not known
- **Login needed:** Any signed-in user
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 14 Jul 2023
- **Updated:** 22 Oct 2024
- **Also known as:** GHSA-6hvv-j432-23cv, GO-2023-1925

## What is CVE-2023-34236?

CVE-2023-34236 is a high-severity vulnerability in weaveworks tf-controller, published on 14 Jul 2023. Any signed-in user can exploit it over the network, with no action from the victim.

### Official description

Weave GitOps Terraform Controller (aka Weave TF-controller) is a controller for Flux to reconcile Terraform resources in a GitOps way. A vulnerability has been identified in Weave GitOps Terraform Controller which could allow an authenticated remote attacker to view sensitive information. This vulnerability stems from Weave GitOps Terraform Runners (`tf-runner`), where sensitive data is inadvertently printed - potentially revealing sensitive user data in their pod logs. In particular, functions `tfexec.ShowPlan`, `tfexec.ShowPlanRaw`, and `tfexec.Output` are implicated when the `tfexec` object set its `Stdout` and `Stderr` to be `os.Stdout` and `os.Stderr`. An unauthorized remote attacker could exploit this vulnerability by accessing these prints of sensitive information, which may contain configurations or tokens that could be used to gain unauthorized control or access to resources managed by the Terraform controller. A successful exploit could allow the attacker to utilize this sensitive data, potentially leading to unauthorized access or control of the system. This vulnerability has been addressed in Weave GitOps Terraform Controller versions `v0.14.4` and `v0.15.0-rc.5`. Users are urged to upgrade to one of these versions to mitigate the vulnerability. As a temporary measure until the patch can be applied, users can add the environment variable `DISABLE_TF_LOGS` to the tf-runners via the runner pod template of the Terraform Custom Resource. This will prevent the logging of sensitive information and mitigate the risk of this vulnerability.

Weakness: CWE-200 (Exposure of Sensitive Information to an Unauthorized Actor)

## Which versions are affected by CVE-2023-34236?

5 open source packages ship an affected version, including github.com/weaveworks/tf-controller. It affects 1 product.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `github.com/weaveworks/tf-controller` | Go | All versions | 0.14.4, 0.15.0-rc.5 |
| `github.com/weaveworks/tf-controller` | Go | All versions | 0.14.4 |
| `github.com/weaveworks/tf-controller` | Go | All versions | 0.14.4 |
| `github.com/weaveworks/tf-controller` | Go | From 0.15.0-rc.1 | 0.15.0-rc.5 |
| `github.com/weaveworks/tf-controller` | Go | From 0.15.0-rc.1 | 0.15.0-rc.5 |

Products: Weave Gitops Terraform Controller.

## How do I fix CVE-2023-34236?

Upgrade github.com/weaveworks/tf-controller to a fixed version for your release line: 0.14.4 or 0.15.0-rc.5.

## Is CVE-2023-34236 being exploited?

There is no known exploitation of CVE-2023-34236 in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for CVE-2023-34236 and fix it if it is affected.

What it is: CVE-2023-34236 is a high-severity vulnerability in weaveworks tf-controller, published on 14 Jul 2023. Any signed-in user can exploit it over the network, with no action from the victim.
Exploitation: There is no known exploitation of CVE-2023-34236 in the wild and no public exploit code.

Affected packages and fixed versions:
- github.com/weaveworks/tf-controller (Go): affected all versions; fixed in 0.14.4, 0.15.0-rc.5
- github.com/weaveworks/tf-controller (Go): affected all versions; fixed in 0.14.4
- github.com/weaveworks/tf-controller (Go): affected all versions; fixed in 0.14.4
- github.com/weaveworks/tf-controller (Go): affected from 0.15.0-rc.1; fixed in 0.15.0-rc.5
- github.com/weaveworks/tf-controller (Go): affected from 0.15.0-rc.1; fixed in 0.15.0-rc.5

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/CVE-2023-34236/ (Markdown: https://insights.sbomify.com/CVE-2023-34236/index.md)
```

## Sources

- CVE record: https://www.cve.org/CVERecord?id=CVE-2023-34236
- NVD: https://nvd.nist.gov/vuln/detail/CVE-2023-34236
- OSV: https://osv.dev/vulnerability/CVE-2023-34236

---
From sbomify Insights: https://insights.sbomify.com/CVE-2023-34236/
Summaries are generated and may contain mistakes; the official description above is the record.
