# CVE-2024-38365: btcd did not correctly re-implement Bitcoin Core's "FindAndDelete()" functionality

> Remote attackers can cause chain splits or denial of service in btcd nodes by exploiting a consensus logic error in script processing.

- **Severity:** High 7.4 (`CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:H/A:H`)
- **Exploited in the wild:** Not known
- **Login needed:** Not needed
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 11 Oct 2024
- **Updated:** 11 Oct 2024
- **Also known as:** CVE-2024-36051, GHSA-27vh-h6mc-q6g8, GO-2024-3189

## What is CVE-2024-38365?

CVE-2024-38365 is a high-severity vulnerability in btcsuite btcd, published on 11 Oct 2024. An attacker can exploit it over the internet without logging in, with no action from the victim.

### Official description

btcd is an alternative full node bitcoin implementation written in Go (golang). The btcd Bitcoin client (versions 0.10 to 0.24) did not correctly re-implement Bitcoin Core's "FindAndDelete()" functionality. This logic is consensus-critical: the difference in behavior with the other Bitcoin clients can lead to btcd clients accepting an invalid Bitcoin block (or rejecting a valid one). This consensus failure can be leveraged to cause a chain split (accepting an invalid Bitcoin block) or be exploited to DoS the btcd nodes (rejecting a valid Bitcoin block). An attacker can create a standard transaction where FindAndDelete doesn't return a match but removeOpCodeByData does making btcd get a different sighash, leading to a chain split. Importantly, this vulnerability can be exploited remotely by any Bitcoin user and does not require any hash power. This is because the difference in behavior can be triggered by a "standard" Bitcoin transaction, that is a transaction which gets relayed through the P2P network before it gets included in a Bitcoin block. `removeOpcodeByData(script []byte, dataToRemove []byte)` removes any data pushes from `script` that contain `dataToRemove`. However, `FindAndDelete` only removes exact matches. So for example, with `script = "<data> <data||foo>"` and `dataToRemove = "data"` btcd will remove both data pushes but Bitcoin Core's `FindAndDelete` only removes the first `<data>` push. This has been patched in btcd version v0.24.2. Users are advised to upgrade. There are no known workarounds for this issue.

Weakness: CWE-670 (Always-Incorrect Control Flow Implementation)

## Which versions are affected by CVE-2024-38365?

3 open source packages ship an affected version, including github.com/btcsuite/btcd. It affects 1 product.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `github.com/btcsuite/btcd` | Go | All versions | 0.24.2-beta.rc1 |
| `github.com/btcsuite/btcd` | Go | All versions | 0.24.2-beta.rc1 |
| `github.com/btcsuite/btcd` | Go | All versions | 0.24.2-beta.rc1 |

Products: Btcd Project Btcd.

## How do I fix CVE-2024-38365?

Upgrade github.com/btcsuite/btcd to 0.24.2-beta.rc1 or later.

## Is CVE-2024-38365 being exploited?

There is no known exploitation of CVE-2024-38365 in the wild and no public exploit code.

## Other vulnerabilities in btcsuite btcd

- [CVE-2022-44797](https://insights.sbomify.com/CVE-2022-44797/): btcd mishandles witness size checking (critical 9.8)
- [CVE-2022-39389](https://insights.sbomify.com/CVE-2022-39389/): Witness Block Parsing DoS Vulnerability in lnd (high 8.2)
- [CVE-2024-34478](https://insights.sbomify.com/CVE-2024-34478/): btcd susceptible to consensus failures (high 7.5)

## Fix prompt for AI coding agents

```text
Check this codebase for CVE-2024-38365 and fix it if it is affected.

What it is: CVE-2024-38365 is a high-severity vulnerability in btcsuite btcd, published on 11 Oct 2024. An attacker can exploit it over the internet without logging in, with no action from the victim.
Exploitation: There is no known exploitation of CVE-2024-38365 in the wild and no public exploit code.

Affected packages and fixed versions:
- github.com/btcsuite/btcd (Go): affected all versions; fixed in 0.24.2-beta.rc1
- github.com/btcsuite/btcd (Go): affected all versions; fixed in 0.24.2-beta.rc1
- github.com/btcsuite/btcd (Go): affected all versions; fixed in 0.24.2-beta.rc1

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/CVE-2024-38365/ (Markdown: https://insights.sbomify.com/CVE-2024-38365/index.md)
```

## Sources

- CVE record: https://www.cve.org/CVERecord?id=CVE-2024-38365
- NVD: https://nvd.nist.gov/vuln/detail/CVE-2024-38365
- OSV: https://osv.dev/vulnerability/CVE-2024-38365

---
From sbomify Insights: https://insights.sbomify.com/CVE-2024-38365/
Summaries are generated and may contain mistakes; the official description above is the record.
