# GHSA-4j93-fm92-rp4m: ASA-2024-003: Missing `BlockedAddressed` Validation in Vesting Module

> An attacker can create a periodic vesting account on a blocked address, potentially causing a blockchain halt via denial of service.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** Any signed-in user
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 21 Feb 2024
- **Also known as:** GO-2024-2572

## What is GHSA-4j93-fm92-rp4m?

GHSA-4j93-fm92-rp4m is a denial of service vulnerability in github.com/cosmos/cosmos-sdk, published on 21 Feb 2024. Any signed-in user can exploit it over the network, with no action from the victim.

### Official description

## ASA-2024-003: Missing `BlockedAddressed` Validation in Vesting Module

**Component**: Cosmos SDK
**Criticality**: Low
**Affected Versions**: Cosmos SDK versions <= 0.50.3; <= 0.47.8
**Affected Users**: Chain developers, Validator and Node operators
**Impact**: Denial of Service

## Description

A vulnerability was identified in the `x/auth/vesting` module, which can allow a user to create a periodic vesting account on a blocked address, for example a non-initialized module account. Additional validation was added to prevent creation of a periodic vesting account in this scenario.

If this case is triggered, there is the potential for a chain halt if the uninitialized account in question is called by `GetModuleAccount` in `Begin`/`EndBlock` of a module. This combination of an uninitialized blocked module account is not common.  

## Next Steps for Impacted Parties

If your chain has uninitialized blocked module accounts, it is recommended to proactively initialize them, as they are often initialized during a chain migration or during init genesis.

If you are a chain developer on an affected version of the Cosmos SDK, it is advised to update to the latest available version of the Cosmos SDK for your project.  Once a patched version is available, it is recommended that network operators upgrade.

A Github Security Advisory for this issue is available in the Cosmos-SDK [repository](https://github.com/cosmos/cosmos-sdk/security/advisories). For more information about Cosmos SDK, see https://docs.cosmos.network/.

This issue was found by [Dongsam](https://github.com/dongsam) who reported it to the Cosmos Bug Bounty Program on HackerOne on January 30, 2024. If you believe you have found a bug in the Interchain Stack or would like to contribute to the program by reporting a bug, please see https://hackerone.com/cosmos.

## Addendum

A variant trigger of this issue via the `x/authz` and `x/feegrant` modules was discovered by [Richie](https://github.com/sushiwushi) who reported it to the Cosmos Bug Bounty Program on HackerOne on April 6th, 2024, and was subsequently fixed by the Cosmos SDK team on April 21st, 2024.  The guidance for mitigating this additional variant is the same as the parent advisory, so it is suggested that all chains proactively initialize module accounts if they have not already done so.

## Which versions are affected by GHSA-4j93-fm92-rp4m?

5 open source packages ship an affected version, including github.com/cosmos/cosmos-sdk.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `github.com/cosmos/cosmos-sdk` | Go | All versions | 0.47.9, 0.50.4 |
| `github.com/cosmos/cosmos-sdk` | Go | All versions | 0.47.9 |
| `github.com/cosmos/cosmos-sdk` | Go | All versions | 0.47.9 |
| `github.com/cosmos/cosmos-sdk` | Go | From 0.50.0 | 0.50.4 |
| `github.com/cosmos/cosmos-sdk` | Go | From 0.50.0 | 0.50.4 |

## How do I fix GHSA-4j93-fm92-rp4m?

Upgrade github.com/cosmos/cosmos-sdk to a fixed version for your release line: 0.47.9 or 0.50.4.

## Is GHSA-4j93-fm92-rp4m being exploited?

There is no known exploitation of GHSA-4j93-fm92-rp4m in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-4j93-fm92-rp4m and fix it if it is affected.

What it is: GHSA-4j93-fm92-rp4m is a denial of service vulnerability in github.com/cosmos/cosmos-sdk, published on 21 Feb 2024. Any signed-in user can exploit it over the network, with no action from the victim.
Exploitation: There is no known exploitation of GHSA-4j93-fm92-rp4m in the wild and no public exploit code.

Affected packages and fixed versions:
- github.com/cosmos/cosmos-sdk (Go): affected all versions; fixed in 0.47.9, 0.50.4
- github.com/cosmos/cosmos-sdk (Go): affected all versions; fixed in 0.47.9
- github.com/cosmos/cosmos-sdk (Go): affected all versions; fixed in 0.47.9
- github.com/cosmos/cosmos-sdk (Go): affected from 0.50.0; fixed in 0.50.4
- github.com/cosmos/cosmos-sdk (Go): affected from 0.50.0; fixed in 0.50.4

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-4j93-fm92-rp4m/ (Markdown: https://insights.sbomify.com/GHSA-4j93-fm92-rp4m/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-4j93-fm92-rp4m

---
From sbomify Insights: https://insights.sbomify.com/GHSA-4j93-fm92-rp4m/
Summaries are generated and may contain mistakes; the official description above is the record.
