# GHSA-5fp6-4xw3-xqq3: @keystone-6/core's bundled cuid package known to be insecure

> KeystoneJS uses insecure cuid identifiers by default, allowing potential prediction of IDs; developers should upgrade or configure custom identifiers.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** Not needed
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** No
- **Published:** 12 Jun 2023

## What is GHSA-5fp6-4xw3-xqq3?

GHSA-5fp6-4xw3-xqq3 is a vulnerability in @keystone-6/core, published on 12 Jun 2023. An attacker can exploit it over the internet without logging in, with no action from the victim.

### Official description

### Summary
The `cuid` package used by `@keystone-6/*` and upstream dependencies is deprecated and [marked as insecure by the author](https://github.com/paralleldrive/cuid#status-deprecated-due-to-security-use-cuid2-instead).

As reported by the author
> Cuid and other k-sortable and non-cryptographic ids (Ulid, ObjectId, KSUID, all UUIDs) are all insecure. Use @paralleldrive/cuid2 instead.

### What are doing about this?
- [We are waiting on Prisma](https://github.com/keystonejs/keystone/issues/8282) to add support for [`cuid2`](https://github.com/paralleldrive/cuid2)
- Alternatively, we might default to a random string ourselves

### What can I do about this?
We have added a work-around for users who want to provide custom identifiers in https://github.com/keystonejs/keystone/pull/8645

### What if I need a `cuid`?
The features marked as a security vulnerability by @paralleldrive are sometimes actually needed ([as written in the README of `cuid`](https://github.com/paralleldrive/cuid#motivation)) - the problem is the inherent risks that features like this can have.

You might actually want the features of a monotonically increasing (auto-increment, k-sortable), and timestamp-based id as part of your application, and keystone should support that - but you might not want them by _default_.
This is why this security advisory has been accepted by me (@dcousens), we currently use cuid identifiers by default, and that should change.

### Impact
I have accepted this security advisory on the basis that we don't need this kind of identifier typically, and the need for them should be driven by an application's requirements, not a convenient default.

## Which versions are affected by GHSA-5fp6-4xw3-xqq3?

2 open source packages ship an affected version, including @keystone-6/core.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `@keystone-6/core` | npm | All versions to 5.3.1 | None |
| `@keystone-6/core` | npm | All versions to 5.3.1 | None |

## How do I fix GHSA-5fp6-4xw3-xqq3?

No fix has been published for GHSA-5fp6-4xw3-xqq3 yet. Limit exposure of the affected software until one is available.

## Is GHSA-5fp6-4xw3-xqq3 being exploited?

There is no known exploitation of GHSA-5fp6-4xw3-xqq3 in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-5fp6-4xw3-xqq3 and fix it if it is affected.

What it is: GHSA-5fp6-4xw3-xqq3 is a vulnerability in @keystone-6/core, published on 12 Jun 2023. An attacker can exploit it over the internet without logging in, with no action from the victim.
Exploitation: There is no known exploitation of GHSA-5fp6-4xw3-xqq3 in the wild and no public exploit code.

Affected packages and fixed versions:
- @keystone-6/core (npm): affected all versions up to 5.3.1; no fix listed
- @keystone-6/core (npm): affected all versions up to 5.3.1; no fix listed

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-5fp6-4xw3-xqq3/ (Markdown: https://insights.sbomify.com/GHSA-5fp6-4xw3-xqq3/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-5fp6-4xw3-xqq3

---
From sbomify Insights: https://insights.sbomify.com/GHSA-5fp6-4xw3-xqq3/
Summaries are generated and may contain mistakes; the official description above is the record.