# GHSA-5v93-9mqw-p9mh: Uncaught Panic in ORML Rewards Pallet

> An integer overflow in the ORML Rewards pallet allows attackers to crash nodes via crafted inputs, requiring a patch update.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** Any signed-in user
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 14 Feb 2025

## What is GHSA-5v93-9mqw-p9mh?

GHSA-5v93-9mqw-p9mh is a vulnerability in orml-rewards, published on 14 Feb 2025. Any signed-in user can exploit it over the network, with no action from the victim.

### Official description

## Summary
A vulnerability in the `add_share` function of the **Rewards** pallet (part of the ORML repository) can lead to an uncaught Rust panic when handling user-provided input exceeding the `u128` range.

## Affected Components
- **ORML Rewards** pallet (`rewards/src/lib.rs`)
- Any Substrate-based chain using ORML Rewards with `add_share` accepting unvalidated large `u128` inputs

## Technical Details
- `add_share` performs arithmetic on user-supplied values (`add_amount`) of type `T::Share` (mapped to `u128` in Acala).
- If `add_amount` is large enough (e.g., `i128::MAX`), the intermediate result may overflow and panic on the cast to `u128`.
- Validation occurs only after arithmetic, enabling a crafted input to trigger an overflow.

## Impact
A malicious user submitting a specially crafted extrinsic can cause a panic in the runtime:
- **Denial of Service** by crashing the node process.
- **Potential for invalid blocks** produced by validators.

## Likelihood
This issue is exploitable in production if there exists at least one rewards pool where reward tokens exceed twice the collateral tokens, allowing sufficiently large multiplication to exceed `u128` bounds.

## Remediation
- This issue is fixed in https://github.com/open-web3-stack/open-runtime-module-library/pull/1016

## Backport

The patch have been backported to following release branches:
- polkadot-stable2407
- polkadot-stable2409

A 1.0.1 patch release is made with this fix.

## Which versions are affected by GHSA-5v93-9mqw-p9mh?

2 open source packages ship an affected version, including orml-rewards.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `orml-rewards` | crates.io | All versions | 1.2.1 |
| `orml-rewards` | crates.io | All versions | 1.2.1 |

## How do I fix GHSA-5v93-9mqw-p9mh?

Upgrade orml-rewards to 1.2.1 or later.

## Is GHSA-5v93-9mqw-p9mh being exploited?

There is no known exploitation of GHSA-5v93-9mqw-p9mh in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-5v93-9mqw-p9mh and fix it if it is affected.

What it is: GHSA-5v93-9mqw-p9mh is a vulnerability in orml-rewards, published on 14 Feb 2025. Any signed-in user can exploit it over the network, with no action from the victim.
Exploitation: There is no known exploitation of GHSA-5v93-9mqw-p9mh in the wild and no public exploit code.

Affected packages and fixed versions:
- orml-rewards (crates.io): affected all versions; fixed in 1.2.1
- orml-rewards (crates.io): affected all versions; fixed in 1.2.1

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-5v93-9mqw-p9mh/ (Markdown: https://insights.sbomify.com/GHSA-5v93-9mqw-p9mh/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-5v93-9mqw-p9mh

---
From sbomify Insights: https://insights.sbomify.com/GHSA-5v93-9mqw-p9mh/
Summaries are generated and may contain mistakes; the official description above is the record.