# GHSA-6fqw-j3vm-7f66: Zendframework1 Potential SQL injection in ORDER and GROUP functions

> SQL injection in Zend Framework 1 allows attackers to execute arbitrary SQL commands via ORDER or GROUP BY clauses, potentially leading to data theft or modification.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** Not stated
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 7 Jun 2024

## What is GHSA-6fqw-j3vm-7f66?

GHSA-6fqw-j3vm-7f66 is a SQL injection vulnerability in zendframework/zendframework1, published on 7 Jun 2024. It can be exploited over the network, with no action from the victim.

### Official description

The implementation of ORDER BY and GROUP BY in Zend_Db_Select remained prone to SQL injection when a combination of SQL expressions and comments were used. This security patch provides a comprehensive solution that identifies and removes comments prior to checking validity of the statement to ensure no SQLi vectors occur.

The implementation of ORDER BY and GROUP BY in Zend_Db_Select of ZF1 is vulnerable by the following SQL injection:
```
$db = Zend_Db::factory(/* options here */);
$select = new Zend_Db_Select($db);
$select->from('p');
$select->order("MD5(\"a(\");DELETE FROM p2; #)"); // same with group()
```
The above $select will render the following SQL statement:
```
SELECT `p`.* FROM `p` ORDER BY MD5("a(");DELETE FROM p2; #) ASC
```
instead of the correct one:
```
SELECT "p".* FROM "p" ORDER BY "MD5(""a("");DELETE FROM p2; #)" ASC
```
This security fix can be considered an improvement of the previous ZF2016-02 and ZF2014-04 advisories.

As a final consideration, we recommend developers either never use user input for these operations, or filter user input thoroughly prior to invoking Zend_Db. You can use the Zend_Db_Select::quoteInto() method to filter the input data, as shown in this example:
```
$db    = Zend_Db::factory(...);
$input = "MD5(\"a(\");DELETE FROM p2; #)"; // user input can be an attack
$order = $db->quoteInto("SQL statement for ORDER", $input);

$select = new Zend_Db_Select($db);
$select->from('p');
$select->order($order); // same with group()
```

## Which versions are affected by GHSA-6fqw-j3vm-7f66?

2 open source packages ship an affected version, including zendframework/zendframework1.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `zendframework/zendframework1` | Packagist | All versions | 1.12.20 |
| `zendframework/zendframework1` | Packagist | All versions | 1.12.20 |

## How do I fix GHSA-6fqw-j3vm-7f66?

Upgrade zendframework/zendframework1 to 1.12.20 or later.

## Is GHSA-6fqw-j3vm-7f66 being exploited?

There is no known exploitation of GHSA-6fqw-j3vm-7f66 in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-6fqw-j3vm-7f66 and fix it if it is affected.

What it is: GHSA-6fqw-j3vm-7f66 is a SQL injection vulnerability in zendframework/zendframework1, published on 7 Jun 2024. It can be exploited over the network, with no action from the victim.
Exploitation: There is no known exploitation of GHSA-6fqw-j3vm-7f66 in the wild and no public exploit code.

Affected packages and fixed versions:
- zendframework/zendframework1 (Packagist): affected all versions; fixed in 1.12.20
- zendframework/zendframework1 (Packagist): affected all versions; fixed in 1.12.20

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-6fqw-j3vm-7f66/ (Markdown: https://insights.sbomify.com/GHSA-6fqw-j3vm-7f66/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-6fqw-j3vm-7f66

---
From sbomify Insights: https://insights.sbomify.com/GHSA-6fqw-j3vm-7f66/
Summaries are generated and may contain mistakes; the official description above is the record.