GHSA-7vw7-qx38-37vr Propel2 SQL injection possible with limit() on MySQL
Attackers can execute arbitrary SQL commands via the limit() method in Propel2, leading to data modification or deletion.
- Exploited in the wild
- Not known
- Login needed
- Not needed
- Attackable
- Over the internet
- Victim action needed
- Not needed
- Fix
- Available
What is GHSA-7vw7-qx38-37vr?
GHSA-7vw7-qx38-37vr is a SQL injection vulnerability in propel/propel, published on 20 May 2024. An attacker can exploit it over the internet without logging in, with no action from the victim.
Official description
The limit() query method is susceptible to catastrophic SQL injection with MySQL.
For example, given a model User for a table users:
UserQuery::create()->limit('1;DROP TABLE users')->find();
This will drop the users table!
The cause appears to be a lack of integer casting of the limit input in either Propel\Runtime\ActiveQuery\Criteria::setLimit() or in Propel\Runtime\Adapter\Pdo\MysqlAdapter::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers.
This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection.
This affects all versions of Propel: 1.x, 2.x, and 3.
Which versions are affected by GHSA-7vw7-qx38-37vr?
2 open source packages ship an affected version, including propel/propel.
| Package | Affected | Fixed in |
|---|---|---|
propel/propel Packagist | From 2.0.0-alpha1 | 2.0.0-alpha8 |
propel/propel Packagist | From 2.0.0-alpha1 | 2.0.0-alpha8 |
How do I fix GHSA-7vw7-qx38-37vr?
Upgrade propel/propel to 2.0.0-alpha8 or later.
Use parameterised queries everywhere and never build SQL by joining strings. Upgrade affected software first; a web application firewall only buys time. More about SQL injection.
Is GHSA-7vw7-qx38-37vr being exploited?
There is no known exploitation of GHSA-7vw7-qx38-37vr in the wild and no public exploit code.