# GHSA-cfqx-f43m-vfh7: @saltcorn/server arbitrary file and directory listing when accessing build mobile app results

> An admin user can list arbitrary files and directories on the server via path traversal in the mobile app build endpoint.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** An administrator
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 3 Oct 2024

## What is GHSA-cfqx-f43m-vfh7?

GHSA-cfqx-f43m-vfh7 is a path traversal vulnerability in @saltcorn/server, published on 3 Oct 2024. An attacker needs administrator access to exploit it, with no action from the victim.

### Official description

### Summary

A user with admin permission can read arbitrary file and directory names on the filesystem by calling the `admin/build-mobile-app/result?build_dir_name=` endpoint.  The `build_dir_name` parameter is not properly validated and it's then used to construct the `buildDir` that is read. The file/directory names under the `buildDir` will be returned. 

### Details

- file: https://github.com/saltcorn/saltcorn/blob/v1.0.0-beta.13/packages/server/routes/admin.js#L2884-L2893

```js
router.get(
  "/build-mobile-app/result",
  isAdmin,
  error_catcher(async (req, res) => {
    const { build_dir_name } = req.query; // [1] source
    const rootFolder = await File.rootFolder();
    const buildDir = path.join(
      rootFolder.location,
      "mobile_app",
      build_dir_name // [2]
    );
    const files = await Promise.all(
      fs
        .readdirSync(buildDir) // [3] sink
        .map(async (outFile) => await File.from_file_on_disk(outFile, buildDir))
    );
    [...]
  })
);
```

### PoC

- log into the application as an admin user
- visit the following url: `http://localhost:3000/admin/build-mobile-app/result?build_dir_name=/../../../../../../../../`

**NOTE**: it's possible to only see file and directory names but not to download their content.

### Impact

Information disclosure

### Recommended Mitigation

Resolve the `buildDir` and check if it starts with `${rootFolder.location}/mobile_app`.

## Which versions are affected by GHSA-cfqx-f43m-vfh7?

2 open source packages ship an affected version, including @saltcorn/server.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `@saltcorn/server` | npm | All versions | 1.0.0-beta.14 |
| `@saltcorn/server` | npm | All versions | 1.0.0-beta.14 |

## How do I fix GHSA-cfqx-f43m-vfh7?

Upgrade @saltcorn/server to 1.0.0-beta.14 or later.

## Is GHSA-cfqx-f43m-vfh7 being exploited?

There is no known exploitation of GHSA-cfqx-f43m-vfh7 in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-cfqx-f43m-vfh7 and fix it if it is affected.

What it is: GHSA-cfqx-f43m-vfh7 is a path traversal vulnerability in @saltcorn/server, published on 3 Oct 2024. An attacker needs administrator access to exploit it, with no action from the victim.
Exploitation: There is no known exploitation of GHSA-cfqx-f43m-vfh7 in the wild and no public exploit code.

Affected packages and fixed versions:
- @saltcorn/server (npm): affected all versions; fixed in 1.0.0-beta.14
- @saltcorn/server (npm): affected all versions; fixed in 1.0.0-beta.14

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-cfqx-f43m-vfh7/ (Markdown: https://insights.sbomify.com/GHSA-cfqx-f43m-vfh7/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-cfqx-f43m-vfh7

---
From sbomify Insights: https://insights.sbomify.com/GHSA-cfqx-f43m-vfh7/
Summaries are generated and may contain mistakes; the official description above is the record.