# GHSA-mfjm-vh54-3f96: Scrapy cookie-setting is not restricted based on the public suffix list

> Scrapy allows malicious sites to set cookies for other domains sharing a public suffix, enabling session hijacking or data leakage.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** Not needed
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 1 Mar 2022

## What is GHSA-mfjm-vh54-3f96?

GHSA-mfjm-vh54-3f96 is a vulnerability in scrapy, published on 1 Mar 2022. An attacker can exploit it over the internet without logging in, with no action from the victim.

### Official description

### Impact

Responses from domain names whose public domain name suffix contains 1 or more periods (e.g. responses from `example.co.uk`, given its public domain name suffix is `co.uk`) are able to set cookies that are included in requests to any other domain sharing the same domain name suffix.

### Patches

Upgrade to Scrapy 2.6.0, which restricts cookies with their domain set to any of those in the [public suffix list](https://publicsuffix.org/).

If you are using Scrapy 1.8 or a lower version, and upgrading to Scrapy 2.6.0 is not an option, you may upgrade to Scrapy 1.8.2 instead.

### Workarounds

The only workaround for unpatched versions of Scrapy is to [disable cookies altogether](https://docs.scrapy.org/en/latest/topics/downloader-middleware.html#std-setting-COOKIES_ENABLED), or [limit target domains](https://docs.scrapy.org/en/latest/topics/spiders.html#scrapy.spiders.Spider.allowed_domains) to a subset that does not include domain names with one of the public domain suffixes affected (those with 1 or more periods).

### References
* https://publicsuffix.org/

### For more information

If you have any questions or comments about this advisory:
* [Open an issue](https://github.com/scrapy/scrapy/issues)
* [Email us](mailto:opensource@zyte.com)

## Which versions are affected by GHSA-mfjm-vh54-3f96?

4 open source packages ship an affected version, including scrapy.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `scrapy` | PyPI | All versions | 1.8.2 |
| `scrapy` | PyPI | All versions | 1.8.2 |
| `scrapy` | PyPI | From 2.0.0 | 2.6.0 |
| `scrapy` | PyPI | From 2.0.0 | 2.6.0 |

## How do I fix GHSA-mfjm-vh54-3f96?

Upgrade scrapy to a fixed version for your release line: 1.8.2 or 2.6.0.

## Is GHSA-mfjm-vh54-3f96 being exploited?

There is no known exploitation of GHSA-mfjm-vh54-3f96 in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-mfjm-vh54-3f96 and fix it if it is affected.

What it is: GHSA-mfjm-vh54-3f96 is a vulnerability in scrapy, published on 1 Mar 2022. An attacker can exploit it over the internet without logging in, with no action from the victim.
Exploitation: There is no known exploitation of GHSA-mfjm-vh54-3f96 in the wild and no public exploit code.

Affected packages and fixed versions:
- scrapy (PyPI): affected all versions; fixed in 1.8.2
- scrapy (PyPI): affected all versions; fixed in 1.8.2
- scrapy (PyPI): affected from 2.0.0; fixed in 2.6.0
- scrapy (PyPI): affected from 2.0.0; fixed in 2.6.0

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-mfjm-vh54-3f96/ (Markdown: https://insights.sbomify.com/GHSA-mfjm-vh54-3f96/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-mfjm-vh54-3f96

---
From sbomify Insights: https://insights.sbomify.com/GHSA-mfjm-vh54-3f96/
Summaries are generated and may contain mistakes; the official description above is the record.