GHSA-p5h2-vr99-xm99 silverstripe/framework ChangePasswordForm does not check `Member::canLogIn()`
Not scored
Published
Check this codebase for GHSA-p5h2-vr99-xm99 and fix it if it is affected.
What it is: GHSA-p5h2-vr99-xm99 is an authentication bypass vulnerability in silverstripe/framework, published on 27 May 2024. An attacker can exploit it over the internet without logging in, and only if a user opens a file or follows a link.
Exploitation: There is no known exploitation of GHSA-p5h2-vr99-xm99 in the wild and no public exploit code.
Affected packages and fixed versions:
- silverstripe/framework (Packagist): affected from 3.1.19-rc1; fixed in 3.1.20
- silverstripe/framework (Packagist): affected from 3.1.19-rc1; fixed in 3.1.20
- silverstripe/framework (Packagist): affected from 3.2.4-rc1; fixed in 3.2.5
- silverstripe/framework (Packagist): affected from 3.2.4-rc1; fixed in 3.2.5
- silverstripe/framework (Packagist): affected from 3.3.2-rc1; fixed in 3.3.3
- silverstripe/framework (Packagist): affected from 3.3.2-rc1; fixed in 3.3.3
- silverstripe/framework (Packagist): affected from 3.4.0-rc1; fixed in 3.4.1
- silverstripe/framework (Packagist): affected from 3.4.0-rc1; fixed in 3.4.1
Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.
Reference: https://insights.sbomify.com/GHSA-p5h2-vr99-xm99/ (Markdown: https://insights.sbomify.com/GHSA-p5h2-vr99-xm99/index.md)
Attackers can bypass login restrictions by resetting passwords for users denied access via custom logic, affecting SilverStripe sites using Member::canLogIn() extensions.
- Exploited in the wild
- Not known
- Login needed
- Not needed
- Attackable
- Over the internet
- Victim action needed
- A user has to click or open something
- Fix
- Available
What is GHSA-p5h2-vr99-xm99?
GHSA-p5h2-vr99-xm99 is an authentication bypass vulnerability in silverstripe/framework, published on 27 May 2024. An attacker can exploit it over the internet without logging in, and only if a user opens a file or follows a link.
Official description
After performing a password reset,
ChangePasswordForm::doChangePassword() logs in the user without checking Member::canLogIn(). This presents an issue for sites that are using the extension point in that method to deny access to users (for example members that have not been “approved”, or members that have had their access revoked temporarily). It looks like Member::canLogIn() was originally designed to only be used for checking whether the user is locked out (due to too many incorrect login attempts) but has been opened up to other uses.Which versions are affected by GHSA-p5h2-vr99-xm99?
8 open source packages ship an affected version, including silverstripe/framework.
| Package | Affected | Fixed in |
|---|---|---|
silverstripe/framework Packagist | From 3.1.19-rc1 | 3.1.20 |
silverstripe/framework Packagist | From 3.1.19-rc1 | 3.1.20 |
silverstripe/framework Packagist | From 3.2.4-rc1 | 3.2.5 |
silverstripe/framework Packagist | From 3.2.4-rc1 | 3.2.5 |
silverstripe/framework Packagist | From 3.3.2-rc1 | 3.3.3 |
silverstripe/framework Packagist | From 3.3.2-rc1 | 3.3.3 |
2 more packages
silverstripe/framework Packagist | From 3.4.0-rc1 | 3.4.1 |
silverstripe/framework Packagist | From 3.4.0-rc1 | 3.4.1 |
How do I fix GHSA-p5h2-vr99-xm99?
Upgrade silverstripe/framework to a fixed version for your release line: 3.1.20, 3.2.5, 3.3.3 or 3.4.1.
Upgrade, and rotate credentials and sessions that may have been exposed. More about Authentication bypass.
Is GHSA-p5h2-vr99-xm99 being exploited?
There is no known exploitation of GHSA-p5h2-vr99-xm99 in the wild and no public exploit code.