GHSA-qp29-wcc2-vmpc Silverstripe HtmlEditor embed url sanitisation
Insufficient server-side URL sanitization in Silverstripe CMS allows potential Server-Side Request Forgery via the HTML editor's media embedding feature.
- Exploited in the wild
- Not known
- Login needed
- Any signed-in user
- Attackable
- Over the internet
- Victim action needed
- A user has to click or open something
- Fix
- Available
What is GHSA-qp29-wcc2-vmpc?
GHSA-qp29-wcc2-vmpc is a server-side request forgery vulnerability in silverstripe/framework, published on 23 May 2024. Any signed-in user can exploit it over the network, and only if a user opens a file or follows a link.
Official description
"Add from URL" doesn't clearly sanitise URL server side
HtmlEditorField_Toolbar has an action HtmlEditorField_Toolbar#viewfile, which gets called by the CMS when adding a media "from a URL" (i.e. via oembed).
This action gets the URL to add in the GET parameter FileURL. However it doesn't do any URL sanitising server side. The current logic will pass this through to Oembed, which will probably reject most dangerous URLs, but it's possible future changes would break this.
Which versions are affected by GHSA-qp29-wcc2-vmpc?
2 open source packages ship an affected version, including silverstripe/framework.
| Package | Affected | Fixed in |
|---|---|---|
silverstripe/framework Packagist | From 3.0.0 | 3.2.1 |
silverstripe/framework Packagist | From 3.0.0 | 3.2.1 |
How do I fix GHSA-qp29-wcc2-vmpc?
Upgrade silverstripe/framework to 3.2.1 or later.
Upgrade, and send outbound requests through an allow-list that blocks internal addresses. More about Server-side request forgery.
Is GHSA-qp29-wcc2-vmpc being exploited?
There is no known exploitation of GHSA-qp29-wcc2-vmpc in the wild and no public exploit code.