# GHSA-qp29-wcc2-vmpc: Silverstripe HtmlEditor embed url sanitisation

> Insufficient server-side URL sanitization in Silverstripe CMS allows potential Server-Side Request Forgery via the HTML editor's media embedding feature.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** Any signed-in user
- **Attackable:** Over the internet
- **Victim action needed:** A user has to click or open something
- **Fix available:** Yes
- **Published:** 23 May 2024

## What is GHSA-qp29-wcc2-vmpc?

GHSA-qp29-wcc2-vmpc is a server-side request forgery vulnerability in silverstripe/framework, published on 23 May 2024. Any signed-in user can exploit it over the network, and only if a user opens a file or follows a link.

### Official description

"Add from URL" doesn't clearly sanitise URL server side

HtmlEditorField_Toolbar has an action HtmlEditorField_Toolbar#viewfile, which gets called by the CMS when adding a media "from a URL" (i.e. via oembed).

This action gets the URL to add in the GET parameter FileURL. However it doesn't do any URL sanitising server side. The current logic will pass this through to Oembed, which will probably reject most dangerous URLs, but it's possible future changes would break this.

## Which versions are affected by GHSA-qp29-wcc2-vmpc?

2 open source packages ship an affected version, including silverstripe/framework.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `silverstripe/framework` | Packagist | From 3.0.0 | 3.2.1 |
| `silverstripe/framework` | Packagist | From 3.0.0 | 3.2.1 |

## How do I fix GHSA-qp29-wcc2-vmpc?

Upgrade silverstripe/framework to 3.2.1 or later.

## Is GHSA-qp29-wcc2-vmpc being exploited?

There is no known exploitation of GHSA-qp29-wcc2-vmpc in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-qp29-wcc2-vmpc and fix it if it is affected.

What it is: GHSA-qp29-wcc2-vmpc is a server-side request forgery vulnerability in silverstripe/framework, published on 23 May 2024. Any signed-in user can exploit it over the network, and only if a user opens a file or follows a link.
Exploitation: There is no known exploitation of GHSA-qp29-wcc2-vmpc in the wild and no public exploit code.

Affected packages and fixed versions:
- silverstripe/framework (Packagist): affected from 3.0.0; fixed in 3.2.1
- silverstripe/framework (Packagist): affected from 3.0.0; fixed in 3.2.1

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-qp29-wcc2-vmpc/ (Markdown: https://insights.sbomify.com/GHSA-qp29-wcc2-vmpc/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-qp29-wcc2-vmpc

---
From sbomify Insights: https://insights.sbomify.com/GHSA-qp29-wcc2-vmpc/
Summaries are generated and may contain mistakes; the official description above is the record.