GHSA-rxhx-9fj6-6h2m enum_map macro can cause UB when `Enum` trait is incorrectly implemented
Incorrect manual implementation of the Enum trait in the enum-map crate can lead to uninitialized memory usage and arbitrary code execution.
- Exploited in the wild
- Not known
- Login needed
- Not needed
- Attackable
- Not stated
- Victim action needed
- Not needed
- Fix
- Available
What is GHSA-rxhx-9fj6-6h2m?
GHSA-rxhx-9fj6-6h2m is a memory corruption vulnerability in enum-map, published on 17 Feb 2022.
Official description
Affected versions of this crate did not properly check the length of an enum when using enum_map! macro, trusting user-provided length.
When the LENGTH in the Enum trait does not match the array length in the EnumArray trait, this can result in the initialization of the enum map with uninitialized types, which in turn can allow an attacker to execute arbitrary code.
This problem can only occur with a manual implementation of the Enum trait, it will never occur for enums that use #[derive(Enum)].
Example code that triggers this vulnerability looks like this:
enum E {
A,
B,
C,
}
impl Enum for E {
const LENGTH: usize = 2;
fn from_usize(value: usize) -> E {
match value {
0 => E::A,
1 => E::B,
2 => E::C,
_ => unimplemented!(),
}
}
fn into_usize(self) -> usize {
self as usize
}
}
impl<V> EnumArray<V> for E {
type Array = [V; 3];
}
let _map: EnumMap<E, String> = enum_map! { _ => "Hello, world!".into() };
The flaw was corrected in commit b824e23 by putting LENGTH property on sealed trait for macro to read.
Which versions are affected by GHSA-rxhx-9fj6-6h2m?
3 open source packages ship an affected version, including enum-map.
| Package | Affected | Fixed in |
|---|---|---|
enum-map crates.io | From 2.0.0-2 | 2.0.2 |
enum-map crates.io | From 2.0.0-2 | 2.0.2 |
enum-map crates.io | From 2.0.0-2 | 2.0.2 |
How do I fix GHSA-rxhx-9fj6-6h2m?
Upgrade enum-map to 2.0.2 or later.
Upgrade to the fixed version. Memory-safe languages, compiler hardening and fuzzing prevent most new cases. More about Memory corruption.
Is GHSA-rxhx-9fj6-6h2m being exploited?
There is no known exploitation of GHSA-rxhx-9fj6-6h2m in the wild and no public exploit code.
Sources
Also known as RUSTSEC-2022-0010.