# GHSA-wxf3-4fvj-vqqx: Unsafe plugins can be installed via pack import by tenant admins

> Tenant admins can bypass unsafe plugin restrictions via pack import, allowing access to data from other tenants.

- **Severity:** Not scored
- **Exploited in the wild:** Not known
- **Login needed:** Any signed-in user
- **Attackable:** Over the internet
- **Victim action needed:** Not needed
- **Fix available:** Yes
- **Published:** 27 Jul 2023

## What is GHSA-wxf3-4fvj-vqqx?

GHSA-wxf3-4fvj-vqqx is a missing authorization vulnerability in @saltcorn/cli, published on 27 Jul 2023. Any signed-in user can exploit it over the network, with no action from the victim.

### Official description

### Summary
Unsafe plugins (for instance `sql-list`) can be installed in subdomain tenants via pack import even if unsafe plugin installation for tenants is disables

### Details
I have an example
https://bot20230704.saltcorn.com/view/all_plugins
It's publicly accessible (but has not so secure values except list of tenants).
But using this mech one can read **any** data from other tenants.

### Impact
All tenants of installation (i.e. `saltcorn.com`), can be compromised from tenant user has admin access. If an untrusted user has admin rights to a tenant instance, they will be able to install a plug-in that can access information from other tenants

### Revived after 0.8.7
After patch in 0.8.7 this is not fixed completely.

Here are steps to reproduce:
1. Publish to NPM plugin that was not approved by admin (in case of saltcorn.com) by @glutamate. I've just published this one: https://www.npmjs.com/package/saltcorn-qrcode
2. Publish somewhere plugin store that includes plugin from previous step: https://gist.github.com/pyhedgehog/f1fd7cb13f4d0a7ccf6a965748d19bd2
3. Add plugin store link to tenant store.
4. Install plugin.
5. Use it in tenant: https://bot20230704.saltcorn.com/view/testqr_show/1

Here are logic:
Unsafe plugins checked against this list:
https://github.com/saltcorn/saltcorn/blob/99fe277e497fd193bb070acd8c663aa254a9907c/packages/server/load_plugins.js#L191
But it's under control of tenant admin, not server admin.
Proposed login:
```javascript
const safes = getRootState().getConfig("available_plugins",[]).filter(p=>!p.unsafe).map(p=>p.location);
```

## Which versions are affected by GHSA-wxf3-4fvj-vqqx?

2 open source packages ship an affected version, including @saltcorn/cli.


| Package | Ecosystem | Affected | Fixed in |
| --- | --- | --- | --- |
| `@saltcorn/cli` | npm | All versions | 0.8.8-beta.2 |
| `@saltcorn/cli` | npm | All versions | 0.8.8-beta.2 |

## How do I fix GHSA-wxf3-4fvj-vqqx?

Upgrade @saltcorn/cli to 0.8.8-beta.2 or later.

## Is GHSA-wxf3-4fvj-vqqx being exploited?

There is no known exploitation of GHSA-wxf3-4fvj-vqqx in the wild and no public exploit code.

## Fix prompt for AI coding agents

```text
Check this codebase for GHSA-wxf3-4fvj-vqqx and fix it if it is affected.

What it is: GHSA-wxf3-4fvj-vqqx is a missing authorization vulnerability in @saltcorn/cli, published on 27 Jul 2023. Any signed-in user can exploit it over the network, with no action from the victim.
Exploitation: There is no known exploitation of GHSA-wxf3-4fvj-vqqx in the wild and no public exploit code.

Affected packages and fixed versions:
- @saltcorn/cli (npm): affected all versions; fixed in 0.8.8-beta.2
- @saltcorn/cli (npm): affected all versions; fixed in 0.8.8-beta.2

Task:
1. Search the dependency manifests and lockfiles (for example package.json, package-lock.json, requirements.txt, poetry.lock, uv.lock, pom.xml, build.gradle, go.mod, Cargo.lock, Gemfile.lock) and any Dockerfiles for the affected packages, including transitive dependencies.
2. If an affected version is in use, upgrade it to the fixed version for its release line with the project's package manager, so the lockfile is regenerated. Prefer the smallest upgrade that fixes it.
3. If there is no fix, or the upgrade would break the build, do not guess: explain the risk and the safest workaround instead.
4. Run the tests and summarise what changed and why.
5. If nothing in the project is affected, say so and change nothing.

Reference: https://insights.sbomify.com/GHSA-wxf3-4fvj-vqqx/ (Markdown: https://insights.sbomify.com/GHSA-wxf3-4fvj-vqqx/index.md)
```

## Sources

- OSV: https://osv.dev/vulnerability/GHSA-wxf3-4fvj-vqqx

---
From sbomify Insights: https://insights.sbomify.com/GHSA-wxf3-4fvj-vqqx/
Summaries are generated and may contain mistakes; the official description above is the record.